Fix how Node options are specified for build step and production #3603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Specify Node options via appsettings.json rather than secrets file - Stop specifying Node options for build step; defaults are fine
Nateowami
force-pushed
the
fix/node-options-build-and-prod
branch
from
9c77b41 to
e05733a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3603 +/- ##
=======================================
Coverage 82.82% 82.82%
=======================================
Files 610 610
Lines 37216 37216
Branches 6077 6077
=======================================
Hits 30824 30824
Misses 5477 5477
Partials 915 915 ☔ View full report in Codecov by Sentry. |
marksvc
approved these changes
Dec 4, 2025
Collaborator
marksvc
left a comment
marksvc
left a comment
There was a problem hiding this comment.
@marksvc reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Nateowami)
Collaborator
|
Experimentation found that as low as --max_old_space_size=619 was able to build. |
Nateowami
added
critical path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is